refactor(graph-gateway): simplify subgraph deployments resolution #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
force-pushed
the
lnsd/deployments-resolution-simplification
branch
from
7fa51d2 to
7747db7
Compare
3 tasks
Co-authored-by: Theo Butler <theodusbutler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handle_client_query_inner()function performs a series of steps necessary for the subgraph query but not for the deployment query.resolve_subgraph_deployments()function to resolve the deployments associated with a subgraph and filter those not associated with the same chain.graphqlresponses module to thegateway-frameworkcrate.IntoResponsefor theErrortype to use aResultas the handler return type and the?sigil, improving the code readability.